Replace ':'s in metric name by '_' #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows ekg-statsd to be used with servant-ekg, which generates
metrics like
servant.path.accounts.:accountId.GET.time_ms.max:113.571281|g
So, having a colon in the metric name, terminating the name part too early.
Both StatsD and Dogstatsd behave like this.
|
Shouldn't this be documented somewhere? |
|
One would hope to find documentation about such a format, but I had to look at the source to determine the behavior. As for documenting it here, I guess that would be nice. I'll add something to the module haddock. |
|
This PR is ready for review. |
23Skidoo
approved these changes
May 15, 2020
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows ekg-statsd to be used with servant-ekg, which generates metrics like
So, having a colon in the metric name, terminating the name part too early.
Both StatsD and Dogstatsd behave like this.