Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split retrieve_IDs off from retrieve_data() #5

Closed
1 task
katrinleinweber opened this issue Jan 13, 2018 · 2 comments
Closed
1 task

split retrieve_IDs off from retrieve_data() #5

katrinleinweber opened this issue Jan 13, 2018 · 2 comments

Comments

@katrinleinweber
Copy link
Collaborator

katrinleinweber commented Jan 13, 2018

Extract to different function? If yes, by scraping IDs from paged URL returns (official examples), or by storing the URLs as intermediate result, plus providing helper functions to narrow that result down to the IDs?

Or, implement as an internal loop-back in retrieve_data(…, searchType = "taxon") based on new parameter taxon_data = TRUE?

  • ask, whether only taxon search can return multiple IDs
@katrinleinweber katrinleinweber changed the title How to handle multiple IDs? split retrieve_IDs off from retrieve_data() Jan 18, 2018
@katrinleinweber
Copy link
Collaborator Author

While working on #16 I noticed that it's difficult to explain why something called …data returns an ID vector. I already implemented #21, so I might as well:

  • align the function names entirely,
  • move them with the aggregate… helpers into different files, and
  • let one call the other, when needed.

@katrinleinweber
Copy link
Collaborator Author

Now part of #54.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant