Correct bug of PR #34 - old javascript function name #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(in javascript, the function was renamed from showtaskform to actualtime_showTaskForm, but one change was missing in ajax/timer.php)
Multiconecta
force-pushed
the
wrong_function_name
branch
from
b04fd2c
to
d7e95b8
Compare
Multiconecta
added a commit
to Multiconecta/actualtime
that referenced
this pull request
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In javascript (js/actualtime.js), the function was renamed from showtaskform to actualtime_showTaskForm, but one change was missing in ajax/timer.php, causing error on clicking the link on popup message when the user tries to start a timer but has a timer already on in another task.
Sorry for that. As a javascript hook that opens in EVERY page, I changed some common names to be sure to avoid any collision with other plugins' functions and fields names.