Control which interface can see timers and include closed box timer #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(default is show times only to users in Standard interface)
Didn't have any purpose, only the first setting for initial tests
|
Found a bug in post-show-item hook, sometimes the item in parameter is not an object, causing a php error. I could find it with a Solution item. It is an array, instead of an object. Patching the function to check if item is an object and also if it has the getType method before invoking it. |
in post-show-item hook. Usually ['item'] should be a Glpi object but there are cases where it is just an array (like in Solution case), that would throw a php error if not tested before.
Multiconecta
added a commit
to Multiconecta/actualtime
that referenced
this pull request
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #35 , according to the finds of issue's discussion.