Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest okio #22

Open
FabianTerhorst opened this issue Jun 1, 2016 · 5 comments
Open

Update to latest okio #22

FabianTerhorst opened this issue Jun 1, 2016 · 5 comments
Milestone
1.0

Comments

@FabianTerhorst
Copy link
Contributor

Okio 1.8 added a new APIs to match byte strings: indexOf(), startsWith(), and endsWith(). This should improve the performance for reading XML tags and attributes in your case.
@FabianTerhorst
Copy link
Contributor Author

Here is how moshi implemeted this: square/moshi@4925755

@sockeqwe
Copy link
Contributor

sockeqwe commented Jun 1, 2016

Thanks, it's on my to do list, not sure when I will find time for that ...

@FabianTerhorst
Copy link
Contributor Author

Off-topic, but retrofit needs an update too i think, because I don't get a callback.

@sockeqwe
Copy link
Contributor

sockeqwe commented Jun 1, 2016

Hm, we use it in production with Retrofit 2.0.0 and we don't have any issues.
please double check and open a new issue for that in case that there is a bug

@FabianTerhorst
Copy link
Contributor Author

Ok I will open a new issue with code

@sockeqwe sockeqwe added this to the 1.0 milestone Jun 27, 2016
@sockeqwe sockeqwe changed the title Update to okio 1.8 Update to latest okio Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@sockeqwe @FabianTerhorst