Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-cleary-samples - submodules removed #9

Closed
cleary opened this issue Mar 26, 2021 · 3 comments
Closed

Clean-cleary-samples - submodules removed #9

cleary opened this issue Mar 26, 2021 · 3 comments

Comments

@cleary
Copy link
Collaborator

cleary commented Mar 26, 2021

Hi @yaxu,
I've updated my sample set to

  • not use submodules
  • move the cleanmeta file into the subdir containing the samples

Could you give it another update/try please?

Also, I'm still working on the cello sets for the moment, so I've left them out - once I've got their layout confirmed I will move them in -

[edit] Quick question, is the Clean- prefix still required? I'd rather not maintain a separate repository just for this - ideally I'd just like to add the orig sample repos to the quark deps

@yaxu
Copy link
Member

yaxu commented Mar 26, 2021

Yes I was thinking the same - ditch Clean-cleary-samples and add samples-flbass directly to the deps of this repository.

Now we're not in the main supercollider quark namespace I don't think we need to stick Clean- in front of everything. samples- is fine as a prefix and we can recommend that for other contributions.

@cleary
Copy link
Collaborator Author

cleary commented Mar 26, 2021

great! I'll get an updated pr shortly :)

@cleary cleary closed this as completed Mar 26, 2021
@yaxu
Copy link
Member

yaxu commented Mar 26, 2021

@cleary I already updated the Clean-samples.quark https://github.com/tidalcycles/Clean-Samples/blob/main/Clean-Samples.quark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants