Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding mongodbnotify to community #2505

Merged
merged 3 commits into from
Jul 3, 2024
Merged

adding mongodbnotify to community #2505

merged 3 commits into from
Jul 3, 2024

Conversation

bsbishop
Copy link
Contributor

This uses an Atlas-MongoDB cluster (M0-free) to allow for notifications to be sent from anywhere but I mainly built it to allow Tidbyt to display notifications from Home Assistant.
mongodb_notify

@bsbishop bsbishop requested a review from matslina as a code owner June 11, 2024 16:09
@tidbyt
Copy link

tidbyt bot commented Jun 11, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

@tidbyt-bot
Copy link

tidbyt-bot commented Jun 11, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bsbishop
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@bsbishop
Copy link
Contributor Author

Any movement on this? I'll be happy to hop on a call and explain / demonstrate, if it helps.

id: mongodb-notify
name: MongoDB Notify
summary: Message notifications
desc: Uses MongoDB for notifications. Can be used with Home Assistant to get Notifications to Tidbyt.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the app description a bit? Would be good if it explained that users will likely have to go read the README here in the community repo to get this set up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @matslina,
I've updated the desc as you requested.

@bsbishop bsbishop requested a review from matslina June 21, 2024 17:21
@matslina matslina merged commit be3344f into tidbyt:main Jul 3, 2024
2 checks passed
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants