Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fix various issues related to the scene migration #13981

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Feb 3, 2024

This PR fixes the open issues related to lifecycle events using the new scene handling. In detail:

- applicationWillResignActive
+ sceneWillResignActive

- applicationDidBecomeActive
+ sceneDidBecomeActive

- applicationDidEnterBackground
+ sceneDidEnterBackground

- applicationWillEnterForeground
+ sceneWillEnterForeground

In addition, it fixes several issues related to open-arguments (mapped to Ti.App.arguments.

Test Case

const win = Ti.UI.createWindow({ backgroundColor: '#fff' });

Ti.App.addEventListener('resume', () => console.warn('Resuming'));
Ti.App.addEventListener('resumed', () => console.warn('Resumed'));
Ti.App.addEventListener('pause', () => console.warn('Pausing'));
Ti.App.addEventListener('paused', () => console.warn('Paused'));

win.open();

@hansemannn
Copy link
Collaborator Author

@m1ga @cb1kenobi If this works as expected, we could do an RC early next week already (e.g. Tuesday).

@hansemannn hansemannn changed the title fix: map lifecycle events to scene delegates fix(ios): fix various issues related to the scene migration Feb 3, 2024
@hansemannn hansemannn merged commit 6e40edb into tidev:master Feb 11, 2024
5 checks passed
hansemannn added a commit that referenced this pull request Feb 11, 2024
* fix: map lifecycle events to scene delegates

* fix(ios): migrate launch options to scene connection options

* chore: restore remote notifications handler

* fix: fix typo
hansemannn added a commit that referenced this pull request May 26, 2024
This reverts commit bfc87a6.

Revert "fix(ios): fix debug issues with scenes (#13979)"

This reverts commit 8bcd5c3.

Revert "fix(ios): fix various issues related to the scene migration (#13981)"

This reverts commit 6e40edb.

Revert "fix(ios): restore compatibility for Ti.App._resumeRestart() (#13989)"

This reverts commit 3a44b3d.

Revert "fix(ios): fix some open issues related to scenes (#14020)"

This reverts commit a0a3aea.

chore: restore start sequence
hansemannn added a commit that referenced this pull request May 26, 2024
This reverts commit bfc87a6.

Revert "fix(ios): fix debug issues with scenes (#13979)"

This reverts commit 8bcd5c3.

Revert "fix(ios): fix various issues related to the scene migration (#13981)"

This reverts commit 6e40edb.

Revert "fix(ios): restore compatibility for Ti.App._resumeRestart() (#13989)"

This reverts commit 3a44b3d.

Revert "fix(ios): fix some open issues related to scenes (#14020)"

This reverts commit a0a3aea.

chore: restore start sequence

# Conflicts:
#	iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.h
#	iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant