Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): support multi-scene applications #13941

Merged
merged 4 commits into from Jan 12, 2024
Merged

feat(ios): support multi-scene applications #13941

merged 4 commits into from Jan 12, 2024

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Oct 31, 2023 •
edited

This PR adds the base compatibility for multi-scene apps, e.g. for iPadOS, CarPlay and visionOS. I may also add a PoC of defining scene-specific windows on the JS-side as well, but that's a whole different effort. Todos:

  • Verify newly generated app projects
  • Verify backwards compatibility with older apps -> Old apps will break right now. I will need to add a build check to inject the required scene configuration
  • Explore multi-scene JS API -> currently not worth it, as it's only used on iPadOS (CarPlay is also a single window). Once visionOS becomes more relevant in the community, I can look into that again
  • Add scene configuration via CLI hook to restore backwards compatibility

@hansemannn hansemannn changed the title feat: support multi-scene applications feat(ios): support multi-scene applications Oct 31, 2023
@hansemannn hansemannn marked this pull request as draft October 31, 2023 19:13
@hansemannn hansemannn self-assigned this Nov 1, 2023
@hansemannn hansemannn marked this pull request as ready for review November 1, 2023 10:14
@hansemannn
Copy link
Collaborator Author

@janvennemann ping

janvennemann
janvennemann approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! As per discussion with Hans there are no additional backwards compatibility fixes required and existing app work perfectly fine with this change, so this is good to go.

@hansemannn hansemannn merged commit bfc87a6 into tidev:master Jan 12, 2024
5 checks passed
hansemannn added a commit that referenced this pull request Jan 20, 2024
@hansemannn
Revert "feat(ios): support multi-scene applications (#13941)"
4a1d20f 
This reverts commit bfc87a6.
hansemannn added a commit to hansemannn/titanium_mobile that referenced this pull request Jan 30, 2024
@hansemannn
Revert "Revert "feat(ios): support multi-scene applications (tidev#13941
5ecce41 
)""

This reverts commit 4a1d20f.
hansemannn added a commit that referenced this pull request Jan 30, 2024
@hansemannn
fix(ios): fix debug issues with scenes (#13979)
8bcd5c3 
* Revert "Revert "feat(ios): support multi-scene applications (#13941)""

This reverts commit 4a1d20f.

* fix: defer loading kroll-core to scene initialization
hansemannn added a commit that referenced this pull request Jan 31, 2024
@hansemannn
fix(ios): fix debug issues with scenes (#13979)
34e0086 
* Revert "Revert "feat(ios): support multi-scene applications (#13941)""

This reverts commit 4a1d20f.

* fix: defer loading kroll-core to scene initialization
# Conflicts:
#	iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
hansemannn added a commit that referenced this pull request May 26, 2024
@hansemannn
Revert "feat(ios): support multi-scene applications (#13941)"
82203d7 
This reverts commit bfc87a6.

Revert "fix(ios): fix debug issues with scenes (#13979)"

This reverts commit 8bcd5c3.

Revert "fix(ios): fix various issues related to the scene migration (#13981)"

This reverts commit 6e40edb.

Revert "fix(ios): restore compatibility for Ti.App._resumeRestart() (#13989)"

This reverts commit 3a44b3d.

Revert "fix(ios): fix some open issues related to scenes (#14020)"

This reverts commit a0a3aea.

chore: restore start sequence
hansemannn added a commit that referenced this pull request May 26, 2024
@hansemannn
Revert "feat(ios): support multi-scene applications (#13941)"
8570d92 
This reverts commit bfc87a6.

Revert "fix(ios): fix debug issues with scenes (#13979)"

This reverts commit 8bcd5c3.

Revert "fix(ios): fix various issues related to the scene migration (#13981)"

This reverts commit 6e40edb.

Revert "fix(ios): restore compatibility for Ti.App._resumeRestart() (#13989)"

This reverts commit 3a44b3d.

Revert "fix(ios): fix some open issues related to scenes (#14020)"

This reverts commit a0a3aea.

chore: restore start sequence

# Conflicts:
#	iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.h
#	iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees

@hansemannn hansemannn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hansemannn @janvennemann