fix(ios): fix some open issues related to scenes #14020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any update on this one? |
|
I am still waiting for feedback from the reporters if the issues have been fixed. I think the push-related bug was not fixed, yet, after trying around for a day. I would recommend to review and merge this one first and then do the other one separately. |
|
Sounds like a good idea. I'll review it over the weekend as I could reproduce both parts in an app |
hansemannn
added a commit
that referenced
this pull request
May 26, 2024
This reverts commit bfc87a6. Revert "fix(ios): fix debug issues with scenes (#13979)" This reverts commit 8bcd5c3. Revert "fix(ios): fix various issues related to the scene migration (#13981)" This reverts commit 6e40edb. Revert "fix(ios): restore compatibility for Ti.App._resumeRestart() (#13989)" This reverts commit 3a44b3d. Revert "fix(ios): fix some open issues related to scenes (#14020)" This reverts commit a0a3aea. chore: restore start sequence
hansemannn
added a commit
that referenced
this pull request
May 26, 2024
This reverts commit bfc87a6. Revert "fix(ios): fix debug issues with scenes (#13979)" This reverts commit 8bcd5c3. Revert "fix(ios): fix various issues related to the scene migration (#13981)" This reverts commit 6e40edb. Revert "fix(ios): restore compatibility for Ti.App._resumeRestart() (#13989)" This reverts commit 3a44b3d. Revert "fix(ios): fix some open issues related to scenes (#14020)" This reverts commit a0a3aea. chore: restore start sequence # Conflicts: # iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.h # iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix two of the three issues described in #13997 so far:
The
Ti.Network.registerForPushNotificationsissue still needs to be investigates. If someone has a test case, I'm happy to use it!