Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong region name parsing for AWS China #707

Closed
LLluma opened this issue Sep 24, 2023 · 0 comments
Closed

Wrong region name parsing for AWS China #707

LLluma opened this issue Sep 24, 2023 · 0 comments

Comments

@LLluma
Copy link
Contributor

LLluma commented Sep 24, 2023

Describe the bug
For AWS China region base domain is slightly different than for the rest world. It is amazon.com.cn.
Currently AWS domain is hard coded in the sqs.go. Would be nice if that will be configured parameter.

To Reproduce
Deploy service to the China AWS region and use SQS subscription

Expected behavior

  • probeSQS should returns true if it is passed https://sqs.cn-northwest-1.amazonaws.com.cn/123456789/myqueue
  • sqsRegionFromPlainURL should return cn-northwest-1 if it is passed https://sqs.cn-northwest-1.amazonaws.com.cn/123456789/myqueue

I prepared minor changes which is fixing this problem: #702

@LLluma LLluma closed this as completed Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant