handle .resid in augment output when response includes function calls
#1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' into resid-1121 # Conflicts: # tests/testthat/test-utilities.R
|
Would you be able to take a look at this, @alexpghayes? You mentioned some edge cases to be wary of in #1121, so wanted to give you a chance to see this before merging. |
|
Yes, I'll take a look by the end of the week. |
|
I just took a look and this seems fine to me! I don't really remember the implementation details as well as I would like, but I find the tests convincing :). |
alexpghayes
approved these changes
Oct 25, 2022
|
Much appreciated, @alexpghayes! |
|
This pull request has been automatically locked. If you believe the issue addressed here persists, please file a new PR (with a reprex: https://reprex.tidyverse.org) and link to this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1121, related to #946, #937, #124.🐬