Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of matrix column support #1126

Merged
merged 6 commits into from
Nov 8, 2022

Commits on Nov 6, 2022

  1. Document that matrix columns are allowed in augment()

    When the augment() documentation was first written, evidently matrix
    columns were not allowed in tibbles. But they have been supported since
    tibble version 1.0.0: tidyverse/dplyr#3630
    
    For instance, augment.lm() works correctly for a model containing poly()
    or ns() terms, placing those terms in matrix columns as expected.
    capnrefsmmat committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    824a2ef View commit details
    Browse the repository at this point in the history
  2. Allow augment() for survival to default to model.frame()

    This was forbidden in broom 0.5.0 because tibbles did not support matrix
    columns, and Surv() produces matrix columns in the model.frame(). But
    since tibble 1.0.0, matrix columns are supported, and these work fine
    with the default model.frame().
    capnrefsmmat committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    3ad85b4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b081272 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Configuration menu
    Copy the full SHA
    168ea52 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0b12066 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c099c8 View commit details
    Browse the repository at this point in the history