Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Naive SE in tidy.survreg #842

merged 1 commit into from May 21, 2020


Copy link

@karldw karldw commented May 7, 2020

I added code to drop the (Naive SE) column when survreg is run with robust=TRUE. This extra column was causing the issues in #728. It would be possible to include it, but that seems less tidy.

I'm having trouble running the full set of tests, but the survival tests seem fine.

Obviously there are bigger things going on right now. This PR isn't urgent.

Fixes #728

Copy link

Looks great to me! Thanks.🙂

@simonpcouch simonpcouch merged commit cb78f62 into tidymodels:master May 21, 2020
simonpcouch added a commit that referenced this pull request May 21, 2020
@karldw karldw deleted the fix-728 branch May 21, 2020 21:36
Copy link

github-actions bot commented Mar 7, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

tidy.survreg function fails when robust = T in survreg model
2 participants