Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use newly exported glmnet helpers from parsnip #62

Closed
hfrick opened this issue Jun 7, 2021 · 2 comments · Fixed by #77
Closed

Use newly exported glmnet helpers from parsnip #62

hfrick opened this issue Jun 7, 2021 · 2 comments · Fixed by #77
Labels
upkeep maintenance, infrastructure, and similar

Comments

@hfrick
Copy link
Member

hfrick commented Jun 7, 2021

Once the glmnet-related helper functions from parsnip are exported, use them here instead of the copied code.

PR with exports: tidymodels/parsnip#509
@hfrick hfrick added the upkeep maintenance, infrastructure, and similar label Jun 7, 2021
@hfrick
Copy link
Member Author

hfrick commented Jun 15, 2021

update: the PR is now merged

@hfrick hfrick mentioned this issue Aug 24, 2021
Merged
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use glmnet helper functions from parsnip directly tidymodels/censored
1 participant
@hfrick