Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipred engine to rpart #101

Merged
merged 4 commits into from
Nov 2, 2021
Merged

ipred engine to rpart #101

merged 4 commits into from
Nov 2, 2021

Conversation

topepo
Copy link
Member

@topepo topepo commented Oct 26, 2021

This will have to be updated once #96 is merged.

I'll review that, merge, update this branch from master, and make changes.

@topepo topepo marked this pull request as ready for review November 1, 2021 22:33
@topepo topepo requested a review from hfrick November 1, 2021 22:33
hfrick
hfrick approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just added one suggestion to make it a bit clearer why the engine is called rpart when it mentions a function from ipred.

R/bag_tree_rpart.R Outdated Show resolved Hide resolved
man/rmd/bag_tree_rpart.Rmd Outdated Show resolved Hide resolved
@topepo @hfrick
Apply suggestions from code review
8561457 
Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
@topepo topepo merged commit e775f50 into main Nov 2, 2021
@topepo topepo deleted the ipred-changes branch November 2, 2021 15:04
@hfrick hfrick mentioned this pull request Nov 2, 2021
Closed
hfrick added a commit that referenced this pull request Nov 3, 2021
@hfrick
leftover documentation from #101
3e278d5
topepo pushed a commit that referenced this pull request Nov 3, 2021
@hfrick
Fix format of quantile predictions for survival_reg() with the `f…
3def880 
…lexsurv` engine (#102)

* leftover documentation from #101

* return nested tibble

* add test for quantile predictions with flexsurv
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hfrick hfrick hfrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topepo @hfrick