random forest and decision tree updates to party engine #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfrick
reviewed
Apr 27, 2021
|
I suspect some of the slowness to come from |
EmilHvitfeldt
approved these changes
Apr 28, 2021
Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
This reverts commit 32b69a6.
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These allow for tuning parameters to be more easily specified and we don't need the
pecpackage.The prediction code is very slow; we'll look into this later. I suspect that it is related to how
partyreturns the results. For example, for survival predictions, they produce KM objects (survfit) which then need to be used to make a probability prediction.A little will need to happen in
tunewithtunable()and there is a PR indialsfor the parameter objects.