Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why is R-3.3.1 required (vs. 3.3.0)? #16

Closed
ttriche opened this issue Aug 2, 2016 · 4 comments
Closed

why is R-3.3.1 required (vs. 3.3.0)? #16

ttriche opened this issue Aug 2, 2016 · 4 comments

Comments

@ttriche
Copy link

ttriche commented Aug 2, 2016

Are there any 3.3.1-specific features that corrr requires?

@ttriche
Copy link
Author

ttriche commented Aug 2, 2016

update: it doesn't appear that any negative effects occur from using 3.3.0.

However, now I'm curious how to change the default color scheme, add a scale legend, flip the plot left-to-right, and tilt the x axis labels. Time to fiddle with that... ASH abstract deadline looming :-)

@ttriche
Copy link
Author

ttriche commented Aug 2, 2016

The network plot method is awesome. Still needs a legend by default IMHO. If I can figure this out quickly I'll send a PR. If not... I will probably forget about it until I find this old issue via Google.

@drsimonj
Copy link
Collaborator

drsimonj commented Aug 2, 2016

R-3.3.1 is required as this is the version that I am developing on. I'm glad to hear that there are no negative effects occurring in 3.3.0. However, I haven't run tests with 3.3.0, and I plan to continue developing in >= 3.3.1. Thus, my preference is to keep requirement of >= 3.3.1 so as to be safe rather than sorry.

Re other comments, I was tossing with the idea of offering legends and other plot adjustments, so perhaps this is a good opportunity for me to make it happen. I'll open separate issues for legend and colour scheme. Please open issues for any other features you'd like, and do submit a PR if you have quick solution. But I'll be happy to add these features soon!

@drsimonj drsimonj closed this as completed Aug 2, 2016
@github-actions
Copy link

github-actions bot commented Mar 7, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants