Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-values with p.adjust corrections #29

Closed
BobMuenchen opened this issue Oct 28, 2016 · 5 comments
Closed

p-values with p.adjust corrections #29

BobMuenchen opened this issue Oct 28, 2016 · 5 comments
Labels
feature a feature request or enhancement

Comments

@BobMuenchen
Copy link

The bigger the correlation matrix, the greater the chance that many of the correlations that make such a pretty pattern don't differ significantly from zero. It would be nice to see just a matrix of p-values, and as color-coding to the correlations themselves. Thanks for considering it!

@drsimonj
Copy link
Collaborator

Thanks, Bob!

p-values are a topic that have come up a lot. If I find the time, I'll try to incorporate a function in corrr to handle this directly.

In the meantime, you have some nice options in other packages (just mentioning for anyone else who comes across this):

  • RcmdrMisc::rcorr.adjust()
  • psych::corr.test()

After using these, you can make use of the new function, as_cordf() (available in dev version only). If you have a matrix, even of p-values, use as_cordf() to transform it to corrr's correlation data frame format, which you can then feed into any other corrr functions like rplot().

@BobMuenchen
Copy link
Author

Cudos to the psych authors for adding it to corr.test. If I had know that, I wouldn't have bothered adding it to Rcdmr. Thanks for the work-around!

@drsimonj drsimonj added the feature a feature request or enhancement label Nov 13, 2016
@drsimonj
Copy link
Collaborator

drsimonj commented Apr 3, 2017

Note to self, see #44

@drsimonj
Copy link
Collaborator

Closing as issue has been open for over 2 years

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants