Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize #39

Closed
DavisVaughan opened this issue Feb 16, 2019 · 2 comments · Fixed by #50
Closed

Generalize #39

DavisVaughan opened this issue Feb 16, 2019 · 2 comments · Fixed by #50

Comments

@DavisVaughan
Copy link
Member

What if we exported all of the new_preprocessor() functions, and their engines? And then standardized the preprocessor engines to all have a mold() and forge() function attached? Basically how the default engine has process() right now. This would let us export the functionality of what bake_terms_engine() does for us in a clean way, wrapped up in preprocessor$engine$forge() that should have standard args across engines

@DavisVaughan
Copy link
Member Author

DavisVaughan commented Feb 22, 2019

  • fix tests (maybe prioritize this then fix docs)
  • switch order of scream() args
  • switch order of shrink() args
  • fix scream docs
  • fix shrink docs
  • fix engine docs
  • fix mold docs
  • fix forge docs (what to do here since the order is different?)
  • look for uses of preprocessor
  • fix readme and vignettes
  • maybe move mold specific pieces of the engine to the mold-.R file?
  • print method for engines
  • make sure the right things are all exported

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant