Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe move engine$clean() and engine$process() argument checks into the base engine #47

Closed
DavisVaughan opened this issue Feb 23, 2019 · 2 comments
Closed

Maybe move engine$clean() and engine$process() argument checks into the base engine #47

DavisVaughan opened this issue Feb 23, 2019 · 2 comments

Comments

@DavisVaughan
Copy link
Member

So new_engine() could check engine$mold$clean() for an engine arg (not the data as that differs)

and engine$forge$clean() could be checked for engine and new_data
@DavisVaughan
Copy link
Member Author

DavisVaughan commented Mar 1, 2019 •
edited
Loading

Check only forge args in the base engine, not mold$clean() mold$process() because those are different per engine

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavisVaughan