Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdiffr 1.0.0 path argument deprecation #478

Closed
simonpcouch opened this issue Mar 7, 2023 · 1 comment · Fixed by #479
Closed

vdiffr 1.0.0 path argument deprecation #478

simonpcouch opened this issue Mar 7, 2023 · 1 comment · Fixed by #479

Comments

@simonpcouch
Copy link
Collaborator

Seeing warnings like this one on devtools::test():

Warning (test-visualize.R:472): method = "both" behaves nicely
The `path` argument of `expect_doppelganger()` is deprecated as of vdiffr 1.0.0.
simonpcouch added a commit that referenced this issue Mar 7, 2023
@simonpcouch
address vdiffr path deprecation (#478)
0e5ac14 
we introduced this helper in #350 to satisfy a conditional usage requirement, but the default arguments to the wrapped function have changed in the meantime. it doesn't seem we ever set this argument to a non-default value.
@simonpcouch simonpcouch mentioned this issue Mar 7, 2023
Merged
@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

transition to testthat 3e tidymodels/infer
1 participant
@simonpcouch