Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spotify data in learntidymodels #5

Closed
wants to merge 10 commits into from

Conversation

karaesmen
Copy link
Contributor

This PR adds the spotify data set and it's manual in the package.
It also removes palmerpenguins from Depends and Remotes.

@topepo
Copy link
Member

topepo commented Jul 21, 2020

Try updating from master. The PR I just merged probably solves some (hopefully all) of the issues in the tests.

@juliasilge
Copy link
Member

The reason this is failing right now is that palmerpenguins was removed from Remotes. It is not on CRAN yet so it needs to stay in Remotes. On the other hand, embed is back on CRAN, so it can come out of Remotes.

Remotes should look like this:

Remotes:
    rstudio-education/gradethis,
    allisonhorst/palmerpenguins

@juliasilge
Copy link
Member

Oh, unless none of tutorials are using palmerpenguins at all anymore? 🤔 In which case @karaesmen you need to remove it both from Remotes and Suggests.

Remotes is like an extra place where you say where to get a package from.

@juliasilge
Copy link
Member

I'm going to close this very old PR 👍

@juliasilge juliasilge closed this Oct 7, 2021
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants