Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proper glmnet autoplot method #642

Closed
topepo opened this issue Feb 2, 2022 · 2 comments · Fixed by #643
Closed

proper glmnet autoplot method #642

topepo opened this issue Feb 2, 2022 · 2 comments · Fixed by #643
Labels
feature a feature request or enhancement

Comments

@topepo
Copy link
Member

topepo commented Feb 2, 2022

Our training materials have had a function in them for a long time. We should move it here and take a ggrepl dependency.
@topepo topepo added the feature a feature request or enhancement label Feb 2, 2022
@topepo
Copy link
Member Author

topepo commented Feb 2, 2022

@simonpcouch This might be useful to supplement the autoplot() method in stacks.

@topepo topepo mentioned this issue Feb 2, 2022
Merged
topepo added a commit that referenced this issue Feb 17, 2022
@topepo @EmilHvitfeldt @DavisVaughan
glmnet autoplot method for #642 (#643)
e9abdf5 
* glmnet autoplot method

* workflow methods

* add pkgdown entry

* makes labels appear on best_penalty line if present

* Apply suggestions from code review

Co-authored-by: Davis Vaughan <davis@rstudio.com>

* move ggrepl to suggests

* doc updates

* anmespace functions and check for glmnet package

* remove workflow method

* move ... up in order

* A note about ggrepl

* more consistent test files

* fix nocov tags

Co-authored-by: Emil Hvitfeldt <emilhhvitfeldt@gmail.com>
Co-authored-by: Davis Vaughan <davis@rstudio.com>
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

glmnet autoplot method for #642 tidymodels/parsnip
1 participant
@topepo