switch check_type() to use cli package #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilHvitfeldt
commented
Oct 11, 2023
R/misc.R
Outdated
| classes <- map_chr(info$type, function(x) x[1]) | ||
| counts <- vctrs::vec_split(info$variable, classes) | ||
| counts$count <- lengths(counts$val) | ||
| counts$text_len <- cli::console_width() - 19 - (counts$count > 1) - |
There was a problem hiding this comment.
-19 - my count of the length of "• variable found: "
(counts$count > 1) - whether variable has an s or not
nchar(counts$key) - length of the variable type
| variable_collapse <- function(x, width) { | ||
| x <- paste0("{.var ", x, "}") | ||
| if (length(x) == 1) { | ||
| res <- cli::ansi_strtrim(x, width = width) |
There was a problem hiding this comment.
in the unlikely event that the single variable name is too large, i used cli::ansi_strtrim to truncate the variable by itself
simonpcouch
requested changes
Oct 11, 2023
simonpcouch
approved these changes
Oct 12, 2023
tests/testthat/_snaps/ratio.md
Outdated
| @@ -23,7 +25,8 @@ | |||
| Condition | |||
| Error in `step_ratio()`: | |||
| Caused by error in `prep()`: | |||
| ! All columns selected for the step should be double, or integer. | |||
| x All columns selected for the step should be double or integer. | |||
| * 8 factor variables found: `x5`, `x5`, `x5`, `x5`, ... | |||
There was a problem hiding this comment.
What's happening here?
There was a problem hiding this comment.
solved with a call to unique() 0a36bb7 (#1235)
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to close #1217.
This PR switches
check_type()to use {cli} in its errors. Additionally and more importantly, it lists the offending variables and their types 🎉