Construct a "manual" rset for usage in last_fit()
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's a good idea. Go ahead and do that. |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #264
Rather than using
mc_cv(), this now constructs a new "manual" rset object from a set of splits/ids (here, just 1 split and 1 id). This avoids the randomness issue altogether.I think it might be nice to move this manual rset idea to rsample eventually. It would be a simple wrapper around
new_rset()that also has the vctrs/dplyr support built in, but wouldn't carry around any extra attributes. People could usemake_splits()to construct their splits using manual indices, then pass the splits tomanual_rset(). If you like that idea, I could move these pieces to rsample now and then make tune import dev rsample.