transition pull_rset_attributes()
-> rsample::.get_split_args()
#905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #898;
inner_split()
passes along itssplit_args()
tomc_splits()
and friends, which check their dots. We thus cannot just pass along all of the rset attributes, and rsample has already implemented the functionality to decide which attributes are split arguments. :)I went ahead and renamed the variable/argument as well to clarify that there's also a superset
rset_info
that is passed to the functions that cobble together_results
objects.