Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree_frogs -> taxi in "What Makes a Model" #113

Merged
merged 10 commits into from
Jul 9, 2023
Merged

Conversation

simonpcouch
Copy link
Contributor

Minimal changes for the "What Makes a Model" section with an eye for the work in #109. Briefly started some code to visualize the logit but neither of the numeric variables separate outcome classes well so it seems like that visualization might ultimately be a bit confusing—leaving that for follow-up edits. :)

Copy link
Contributor Author

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciating your changes, @hfrick—no edits!🦋

Merge branch '2023-nyr' into 2023-nyr-what-makes

# Conflicts:
#	docs/search.json
#	docs/sitemap.xml
#	docs/slides/03-what-makes-a-model.html
Merge branch '2023-nyr' into 2023-nyr-what-makes

# Conflicts:
#	docs/search.json
#	docs/sitemap.xml
#	docs/slides/03-what-makes-a-model.html
@simonpcouch simonpcouch merged commit 64ffc8b into 2023-nyr Jul 9, 2023
@simonpcouch simonpcouch deleted the 2023-nyr-what-makes branch July 9, 2023 14:32
topepo added a commit that referenced this pull request Jul 11, 2023
* transition tree frogs to taxi data in "Your Data Budget"

* remove redundant `notes`

* update to taxi data

* correct case, stratify by outcome

* ask for logistic regression

* bump bins 20 -> 100

* `table()` -> `count()`

* start with univariate plot of outcome

* use same assignment pattern as classwork

* project so far

* plot event rate before stratifying

* add spinning taxi svg!

* day 1 - don't peek at the test set

* first draft evaluating models

* Advanced class tuning intro and grid search (#106)

* itemize for different workshops

* fix ROC code

* initial files

* render

* a recipe and tuning parameters

* more grid search

* added animations and more hexes

* small update

* Apply suggestions from code review

Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>

* update main page with archive and pkg installs

* updated based on review comments

* name change (this will be the second section)

* small updates

* re-render

* one other reviewer suggestion

---------

Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>

* reverse `tip` factor levels when visualizing (#122)

* Apply suggestions from code review

Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>

* reknit with suggested changes

* back to more complicated tree

* use brier_score in "your turn"

* update classwork

* last set of changes

* use fig.path in evaluating models

ref #121

* racing content files (#131)

* iterative search content files (#132)

* remove old feature engineering files

* remove old data files

* reset scratch files

* remove old tuning slides

* slots for extra slides

* re-render

* Reorganize the case study in Reykjavik to extra slides (#133)

* transit case study files

* note about stacking

* add `fig.path`, name chunks in "Your Data Budget" (#125)

* add `fig.path`, name chunks in "Your Data Budget"

* remove unused files

* update `img` refs

* `tree_frogs` -> `taxi` in "What Makes a Model" (#113)

* `tree_frogs` -> `taxi` in "What Makes a Model"

* add duplicate `images/taxi.png`

* use emil's lovely animated taxi

* model intro: lm -> log reg

* render

* "own model" instead of "log reg"

sync up slides and classwork

* render

---------

Co-authored-by: Hannah Frick <hannah@rstudio.com>

* Feature engineering slides (#127)

* content additions

* small updates

* Apply suggestions from code review

Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
Co-authored-by: Emil Hvitfeldt <emil.hvitfeldt@posit.co>

* Apply suggestions from code review

Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>

* move metrics to previous slides

* missing hexes

* updates form reviewer feedback

* missing hexes

* make hexes on slides sort from a-z

---------

Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
Co-authored-by: Emil Hvitfeldt <emil.hvitfeldt@posit.co>

* Folding in the feature hashing parameters for tuning (#134)

* move gif file to be with the rest of its people

* OMG yes

* add hash tuning

* remove redundant slide (shown better in later section)

* small grid updates

* changes based on reviewer feedback

* adding feature hashing parameters for racing (#135)

* updates with hash features

* add hexes

* Effect encoding extras (#136)

* effect encoding content

* player -> agent

* small updates

* changes for #121

* trim file before new PR so that we can render

* remove old files for #121

* add missing hex

* re-render

* add missing hex

* Annotation changes/fixes and a few minor updates (#138)

* add link to a racing animation

* reduce redundancy

* use a unique slide title to link the annotation

* remove hockey data splitting annotation

* remove validation-set related annotation for final fit

* remove the hockey-related annotation since we don't have the same issue

* more and edit the effect encoding annotations

* remove more hockey annotations and interpretation annotations

* update early stopping annotation

* remove answer before the question :-/

* update the annotation on updating parameter ranges

* validation set annotation about new version of rsample

* delimiters for files in annotations

* re-render

* correct bonsai pkg name

* update intro

* refer back to whole game

* avoid overlap between taxi and header

* change cloud url to a note about slack.

* discuss predictor pre-selection

* no caching

* remove figures in wrong directories

* 2023 nyr render (#145)

* render 01-intro

* render 02-data-budget

* render 03-what-makes-a-model

* render 04-evaluating-models

* render advanced-01-feature-engineering

* render advanced-02-tuning-hyperparameters

* render advanced-03-racing

* render advanced-04-iterative

* render extras-effect-encodings

* re-run with newer quarto version

---------

Co-authored-by: Max Kuhn <mxkuhn@gmail.com>

---------

Co-authored-by: simonpcouch <simonpatrickcouch@gmail.com>
Co-authored-by: Hannah Frick <hannah@rstudio.com>
Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
Co-authored-by: Emil Hvitfeldt <emilhhvitfeldt@gmail.com>
Co-authored-by: Emil Hvitfeldt <emil.hvitfeldt@posit.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants