Add roc_auc_survival()
#390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge commit '4964156d7e2413cb0501357266501abb27652ad6' #Conflicts: # NEWS.md
simonpcouch
approved these changes
Mar 16, 2023
R/surv-roc_survival_auc.R
Outdated
| sensitivity <- sensitivity[not_na] | ||
| specificity <- specificity[not_na] | ||
|
|
||
| auc( 1 - specificity, sensitivity) |
There was a problem hiding this comment.
Feels worth noting that a different pattern exists here:
Lines 212 to 219 in 4a620f3
This is because direction = "minimize"?
There was a problem hiding this comment.
It should have been "maximize" 😅
There was a problem hiding this comment.
I'm still a bit confused here, then—if we want to maximize this metric, shouldn't we pass specificity rather than 1 - specificity, as in the code linked above? Or is the thing labeled specificity actually one_minus_specificity in the first place?
Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
…into survival_curve_auc
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #378, to supply the
roc_auc_survival()metric.