Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roc_survival_curve() #378

Merged
merged 16 commits into from Mar 14, 2023
Merged

Add roc_survival_curve() #378

merged 16 commits into from Mar 14, 2023

Conversation

EmilHvitfeldt
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt commented Mar 1, 2023

This is another PR that extends the work done in #347.

This PR aims to:

  • Add the time-dependent ROC curve function for right-censored data with the function roc_survival_curve()

To be done:

  • More documentation
  • tests
  • references (@topepo I trust you have some here)
  • plotting method?

@EmilHvitfeldt EmilHvitfeldt changed the title Roc survival Add roc_survival_curve() Mar 1, 2023
@EmilHvitfeldt
Copy link
Member Author

Wait for tidymodels/parsnip#893

@topepo
Copy link
Member

topepo commented Mar 1, 2023

Go ahead without references. I'll do a write-up for the Details section with references and some comments on how we are creating the weights and add that via a PR.

@topepo
Copy link
Member

topepo commented Mar 1, 2023

Can you increment the version for each of these PRs (1.1.0.9001 etc)?

@EmilHvitfeldt
Copy link
Member Author

Yes! I will do that

@topepo
Copy link
Member

topepo commented Mar 1, 2023

For autocomplete, it would be better to have roc_curve_survival(). Does the AUC method come in another PR?

@EmilHvitfeldt
Copy link
Member Author

For autocomplete, it would be better to have roc_curve_survival().

Will fix.

Does the AUC method come in another PR?

Yes.

@EmilHvitfeldt EmilHvitfeldt merged commit d3f9db6 into main Mar 14, 2023
@EmilHvitfeldt EmilHvitfeldt deleted the roc_survival branch March 14, 2023 19:24
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants