Hive translations for window functions were no more working (#293)

* hive translation needs to depend on base_odbc_win too * add a NEWS bullet
tidyverse · May 3, 2019 · 56afe40 · 56afe40
1 parent eeb8949
commit 56afe40
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # dbplyr (development version)
 
+* Window functions are now translated correctly for Hive (#293, @cderv).
+
 # dbplyr 1.4.0
 
 ## Breaking changes

diff --git a/R/backend-hive.R b/R/backend-hive.R
@@ -18,7 +18,7 @@ sql_translate_env.Hive <- function(con) {
       quantile = sql_quantile("PERCENTILE"),
       median = sql_median("PERCENTILE")
     ),
-    sql_translator(.parent = base_odbc_agg,
+    sql_translator(.parent = base_odbc_win,
       var = win_aggregate("VARIANCE"),
       quantile = sql_quantile("PERCENTILE", window = TRUE),
       median = sql_median("PERCENTILE", window = TRUE)