Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider local evaluation #200

Closed
hadley opened this issue Jan 2, 2019 · 1 comment

Comments

@hadley
Copy link
Member

@hadley hadley commented Jan 2, 2019

Currently partial_eval() locally evaluates calls of the form pkg::bar() (where pkg is not dplyr), and x$y (which will block #158). It's probably worth reconsidering in the light of unquoting as I think this would make the interface more consistent.

At the same time, we could deprecate local() (since it's basically equivalent to !!). remote() needs to stay in case we have override an SQL function with the same name but a different meaning.

@hadley hadley modified the milestone: v1.2.2 Jan 2, 2019
@hadley hadley added feature and removed wip labels Jan 9, 2019
@hadley hadley added this to the v1.4.0 milestone Jan 9, 2019
@hadley

This comment has been minimized.

Copy link
Member Author

@hadley hadley commented Jan 9, 2019

Leaving local() as is for symmetry with remote() and to minimise breaking changes.

@hadley hadley closed this in 7e77a26 Jan 9, 2019
sebschub added a commit to sebschub/klimageodb that referenced this issue Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.