Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider local evaluation #200

Closed
hadley opened this issue Jan 2, 2019 · 1 comment
Closed

Reconsider local evaluation #200

hadley opened this issue Jan 2, 2019 · 1 comment
Labels
feature a feature request or enhancement func trans 🌍 Translation of individual functions to SQL
Milestone
v1.4.0

Comments

@hadley
Copy link
Member

hadley commented Jan 2, 2019 •
edited
Loading

Currently partial_eval() locally evaluates calls of the form pkg::bar() (where pkg is not dplyr), and x$y (which will block #158). It's probably worth reconsidering in the light of unquoting as I think this would make the interface more consistent.

At the same time, we could deprecate local() (since it's basically equivalent to !!). remote() needs to stay in case we have override an SQL function with the same name but a different meaning.
@hadley hadley added wip work in progress func trans 🌍 Translation of individual functions to SQL labels Jan 2, 2019
@hadley hadley modified the milestone: v1.2.2 Jan 2, 2019
This was referenced Jan 3, 2019
Closed
Closed
@hadley hadley added feature a feature request or enhancement and removed wip work in progress labels Jan 9, 2019
@hadley hadley added this to the v1.4.0 milestone Jan 9, 2019
@hadley
Copy link
Member Author

hadley commented Jan 9, 2019

Leaving local() as is for symmetry with remote() and to minimise breaking changes.

@hadley hadley closed this as completed in 7e77a26 Jan 9, 2019
sebschub added a commit to sebschub/klimageodb that referenced this issue Jun 17, 2019
@sebschub
Update for dbplyr 1.4: Add local()
0f927a3 
See tidyverse/dbplyr#200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement func trans 🌍 Translation of individual functions to SQL
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
1 participant
@hadley