Support case_match()
#1020
Merged
Support case_match()
#1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
approved these changes
Oct 21, 2022
R/translate-sql-conditional.R
Outdated
|
|
||
| x_expr <- enexpr(.x) | ||
| if (!is_symbol(x_expr)) { | ||
| msg <- "{.arg .x} must be a variable, not a {.obj_type_friendly {.x}}." |
There was a problem hiding this comment.
Suggested change
| msg <- "{.arg .x} must be a variable, not a {.obj_type_friendly {.x}}." | |
| msg <- "{.arg .x} must be a variable, not {.obj_type_friendly {.x}}." |
This always trips me up too, but obj_type_friendly adds the article because sometimes its "a" and sometimes its "an"
R/translate-sql-conditional.R
Outdated
| @@ -1,3 +1,87 @@ | |||
| sql_case_match <- function(.x, ..., .default = NULL, .ptype = NULL, error_call = current_call()) { | |||
There was a problem hiding this comment.
I don't think you need error_call here?
R/translate-sql-conditional.R
Outdated
|
|
||
| env <- environment(f) | ||
| f_query <- f[[2]] | ||
| # must handle `c(...)` specially because `translate_sql()` doesn't do what |
R/translate-sql-conditional.R
Outdated
| } | ||
|
|
||
| # catch things like `f(y)` | ||
| if (!vctrs::vec_is(f_query)) { |
There was a problem hiding this comment.
Maybe is_call() would be more evocative of the purpose?
| }) | ||
| }) | ||
|
|
||
| test_that(".x must be a symbol", { |
hadley
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.