Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests to changes in dplyr::tbl_vars() #312

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Adapt tests to changes in dplyr::tbl_vars() #312

merged 2 commits into from
Jun 12, 2019

Conversation

romainfrancois
Copy link
Member

The tests expected a simple character vector, and tidyverse/dplyr#4399 proposes that tbl_vars() returns a structured object of class dplyr_sel_vars with the groups attribute set to host the grouping columns.

This just adapts the test to unstructure the object.

@hadley
Copy link
Member

hadley commented Jun 4, 2019

I think as.character() might be more clear?

@romainfrancois
Copy link
Member Author

✅ Thanks.

@hadley
Copy link
Member

hadley commented Jun 12, 2019

Thanks!

@hadley hadley deleted the tbl_vars branch June 12, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants