Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setOldClass() calls #453

Merged
merged 4 commits into from May 15, 2020
Merged

Add setOldClass() calls #453

merged 4 commits into from May 15, 2020

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented May 14, 2020 •
edited

For compatibility with dplyr 1.0.0.

Closes #448.

@krlmlr krlmlr requested a review from hadley May 14, 2020 05:39
@hadley
Copy link
Member

hadley commented May 14, 2020

Should we do this conditionally onLoad()? I have a feeling you get a bad outcome if both dplyr and dbplyr register.

@hadley
Copy link
Member

hadley commented May 15, 2020

Can you add a news bullet too please?

@hadley hadley merged commit ddec0e8 into tidyverse:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley Awaiting requested review from hadley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird dbplyr error when the dev version of dplyr is installed
2 participants
@krlmlr @hadley