Adds support for Snowflake databases #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hadley PTAL |
hadley
reviewed
Mar 27, 2021
| simulate_snowflake <- function() simulate_dbi("Snowflake") | ||
|
|
||
| #' @export | ||
| sql_table_analyze.Snowflake <- function(con, table, ...) {} |
There was a problem hiding this comment.
Could you add a comment here explaining why, preferably with a link to snowflake docs?
There was a problem hiding this comment.
This was like trying to prove a negative. Could not find an explicit acknowledgement in the docs that we don't need to run the table analysis. I commented and included the link to all SQL commands, hopefully that helps.
hadley
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log10()translationcopy_to()by creating a method with an empty outputlog10()SQL output