Add more translations for Snowflake

[fh-afrachioni]

This request adds a number of additional translations for Snowflake backends, with the intent to translate all functions currently available for Postgres. Specifically, support is added for:

base

• log10
• grepl
• round
• paste and paste0

stringr

• str_c
• str_locate
• str_detect
• str_replace and str_replace_all
• str_remove and str_remove_all
• str_trim and str_squish

lubridate

• day, mday, wday, yday, week, isoweek, month, quarter, isoyear
• seconds, minutes, hours, days, weeks, months, years
• floor_date

This fixes issue #935

[fh-afrachioni]

Reopening after adding backend testing. Any feedback would be appreciated.

[fh-afrachioni]

@mgirlich @hadley The above failing checks seem unrelated to the changes, but I could be mistaken. Happy to address any other feedback!

[hadley]

Thanks for working on this! A bunch of small feedback follows.

[hadley]

@mgirlich could you please take a quick look too? (just to make sure I haven't forgotten anything major since I haven't worked on dbplyr in a while)

[mgirlich]

The default is plural, below is always singular. I see this is also the case for the postgres backend...
Either you simply fix the default to "seconds" or if you want to be more user friendly you could also allow the plural version. Up to you.

[fh-afrachioni]

Good catch, maybe I'll follow up with an update to the postgres backend. Since the singular and plural versions are all supported on both Snowflake (here) and lubridate, I'm expanding the arg list to include both.

[mgirlich]

@fh-afrachioni Looks great overall. Thanks!

[fh-afrachioni]

Thanks for the review, @mgirlich; I just updated with the requested changes. Happy to address anything else!

[fh-afrachioni]

Thanks for the review and approval, @hadley and @mgirlich! Do you know when the next release is planned? I have a team that would love to use these features within the next few weeks.

[hadley]

We've accumulated quite a few new features lately thanks to @mgirlich's hard work. So it would be nice to get a release out in the not too distant future. But no concrete plans yet.