Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group_if, group_at, group_all #2053

Closed
krlmlr opened this issue Aug 4, 2016 · 4 comments · Fixed by #2587
Closed

group_if, group_at, group_all #2053

krlmlr opened this issue Aug 4, 2016 · 4 comments · Fixed by #2587
Assignees
Labels
feature a feature request or enhancement

Comments

@krlmlr
Copy link
Member

krlmlr commented Aug 4, 2016

group_by(everything()) doesn't work, probably because group_by() has mutate() semantics.

group_by_all <- function(.data) group_by_(.data, .dots = colnames(.data))

This is different from rowwise() iff the data contains duplicate rows.

@krlmlr krlmlr added feature a feature request or enhancement and removed feature a feature request or enhancement labels Nov 7, 2016
@hadley hadley added data frame feature a feature request or enhancement labels Feb 2, 2017
@hadley
Copy link
Member

hadley commented Feb 2, 2017

I wonder if we should just provide a variant with select() semantics. group_by_select(), group_by_where()?

@krlmlr
Copy link
Member Author

krlmlr commented Feb 2, 2017

set_group_vars() and add_group_vars()? Simply group()?

@hadley
Copy link
Member

hadley commented Feb 2, 2017

I think it needs to have a similar grammatical form to group_by()

@hadley
Copy link
Member

hadley commented Feb 20, 2017

It now seems obvious that this should be group_by_at(), group_by_if(), group_by_all(), and so I'll give it to @lionel- 🙂

@hadley hadley added nse and removed data frame labels Feb 20, 2017
@hadley hadley changed the title FR: Grouping operator to group by all columns group_if, group_at, group_all Feb 27, 2017
lionel- added a commit to lionel-/dplyr that referenced this issue Mar 28, 2017
lionel- added a commit to lionel-/dplyr that referenced this issue Mar 28, 2017
lionel- added a commit to lionel-/dplyr that referenced this issue Mar 29, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants