Release dplyr 0.8.0

[romainfrancois]

Prepare for release:

• devtools::check_win_devel()
• rhub::check_for_cran()
• revdepcheck::revdep_check(num_workers = 4)
• Polish NEWS
• If new failures, update email.yml then revdepcheck::revdep_email_maintainers()
• Prepare pre-release blog post soliciting feedback
• check tidyr::unnest()
• revert warn on cases like min(c(NA, NA), na.rm = TRUE) in hybrid #4123
• use unique_names() instead of universal_names() in name generation : using unique_names() and more natural numbering #4157

Perform release:

• Create RC branch (for bigger releases)
• Bump version (in DESCRIPTION and NEWS)
• devtools::check_win_devel() (again!)
• devtools::submit_cran()
• pkgdown::build_site()
• Approve email

Wait for CRAN...

• Tag release
• Merge RC back to master branch
• Bump dev version
• Write blog post
• Tweet
• Write final blog post
• Add link to blog post in pkgdown news menu

Template from r-lib/usethis#338

[hadley]

Let's aim for early January Feb 1 Feb 8 for release

[romainfrancois]

✅ devtools::check_win_devel()

this notification has been generated automatically.
Your package dplyr_0.7.99.9000.tar.gz has been built (if working) and checked for Windows.
Please check the log files and (if working) the binary package at:
https://win-builder.r-project.org/Y3w17BwqaQe8
The files will be removed after roughly 72 hours.
Installation time in seconds: 640
Check time in seconds: 363
Status: 1 NOTE
R Under development (unstable) (2018-12-17 r75857)

The note is because I changed the email:

* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Hadley Wickham <romain@rstudio.com>'

Version contains large components (0.7.99.9000)

[romainfrancois]

⚠️

Build ID: dplyr_0.7.99.9000.tar.gz-9856749177e841489280df17cd88365f
Platform: Fedora Linux, R-devel, clang, gfortran

https://builder.r-hub.io/status/dplyr_0.7.99.9000.tar.gz-9856749177e841489280df17cd88365f

* checking re-building of vignette outputs ... WARNING
Error in re-building vignettes:
  ...
`geom_smooth()` using method = 'gam' and formula 'y ~ s(x, bs = "cs")'
Warning: Removed 1 rows containing non-finite values (stat_smooth).
Warning: Removed 1 rows containing missing values (geom_point).
Quitting from lines 224-237 (dplyr.Rmd) 
Error: processing vignette 'dplyr.Rmd' failed with diagnostics:
X11 font -adobe-helvetica-%s-%s-*-*-%d-*-*-*-*-*-*-*, face 1 at size 11 could not be loaded
Execution halted

[romainfrancois]

The Debian Linux, R-devel, GCC ASAN/UBSAN rhub says ERROR
https://builder.r-hub.io/status/dplyr_0.7.99.9000.tar.gz-d3b96eac4a25411b88544c378b08f935

The only thing I find in there is these lines:

vendor/sqlite3/sqlite3.c:61270:14: runtime error: member access within misaligned address 0x7ff692d82f4e for type 'struct BtCursor', which requires 8 byte alignment
0x7ff692d82f4e: note: pointer points here
 62 65 27 00 01 00  01 00 00 00 00 00 0d 00  27 6c 6f 6e 67 20 69 6e  74 27 00 00 00 00 0a 00  27 75
             ^

Not sure what to do with this.

[romainfrancois]

Last run of check_win_devel() ✅ , looks like we're ready:

Dear package maintainer,

this notification has been generated automatically.
Your package dplyr_0.8.0.tar.gz has been built (if working) and checked for Windows.
Please check the log files and (if working) the binary package at:
https://win-builder.r-project.org/Vn8iIKJvCRLc
The files will be removed after roughly 72 hours.
Installation time in seconds: 497
Check time in seconds: 280
Status: 1 NOTE
R Under development (unstable) (2019-02-07 r76069)

All the best,
Uwe Ligges
(CRAN maintainer of binary packages for Windows)

(the note is because I used my email address instead of @hadley's )

[krlmlr]

Ran all tests from v0.7.8 against current master -- 84 failures, mostly false positives.

Empty data frames now always return one row after summarize() . Do we need to be more explicit about this in NEWS? (Is this intended?)

To replicate:

git rm -- tests
git checkout v0.7.8 -- tests

[romainfrancois]

rhub::check_with_sanitizers() seems happy: https://builder.r-hub.io/status/dplyr_0.8.0.tar.gz-1693912936554d7e96d1096c9231b682

[...]
6669#> Build step 'Send files or execute commands over SSH' changed build result to SUCCESS
6670#> Pinging https://builder.r-hub.io/build/SUCCESS/dplyr_0.8.0.tar.gz-1693912936554d7e96d1096c9231b682/2019-02-08T10:01:11Z
6671#> {"status":"ok"}
6672#> Finished: SUCCESS

[romainfrancois]

@krlmlr you mean tibbles with 0 rows ?

[krlmlr]

Yes.

[romainfrancois]

summarise() always return one row per group, no matter what, I don't think we need to mention this

[krlmlr]

This was different in v0.7.8.

[romainfrancois]

@batpigandme Anything to do about the * pkgdown::build_site() item or is it automatic now ?

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/