Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench-compare.R functions #4675

Closed
romainfrancois opened this issue Dec 25, 2019 · 3 comments · Fixed by #4696
Closed

bench-compare.R functions #4675

romainfrancois opened this issue Dec 25, 2019 · 3 comments · Fixed by #4696
Assignees

Comments

@romainfrancois
Copy link
Member

Do we still need these : bench_tbls(), compare_tbls(), compare_tbls2(), eval_tbls(), eval_tbls2() ?

@hadley
Copy link
Member

hadley commented Dec 25, 2019

I think the bench functions can be ditched, but I think we use compare_tbls() still (in dbplyr IIRC — so we could also remove in the next version). Probably worth a bit of github code searching to confirm.

@hadley
Copy link
Member

hadley commented Jan 1, 2020

The only uses of compare_tbls[2] are in tests, so I think we can deprecate them all without causing substantial pain. @ianmcook please let us know if you think differently.

@ianmcook
Copy link
Contributor

ianmcook commented Jan 2, 2020

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants