Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

any chance of adding number of observations to glimpse()? #692

Closed
pssguy opened this issue Oct 13, 2014 · 4 comments
Closed

any chance of adding number of observations to glimpse()? #692

pssguy opened this issue Oct 13, 2014 · 4 comments
Assignees
Labels
Milestone

Comments

@pssguy
Copy link

@pssguy pssguy commented Oct 13, 2014

would save additional str() or nrow()

@hadley hadley added the feature label Oct 30, 2014
@hadley hadley added this to the 0.3.1 milestone Oct 30, 2014
@hadley hadley self-assigned this Oct 30, 2014
@hadley
Copy link
Member

@hadley hadley commented Oct 30, 2014

Sure. But maybe you'd like to try implementing it yourself and submitting a PR?

@pssguy
Copy link
Author

@pssguy pssguy commented Oct 30, 2014

I'll need to read up on pull requests

I have the couple of lines of code which appear to work

@hadley
Copy link
Member

@hadley hadley commented Nov 19, 2014

Can you send me those lines of code?

@pssguy
Copy link
Author

@pssguy pssguy commented Nov 19, 2014

Sorry forgot about doing the pull request

This is what I had for glimpse.R. The outer lines are already part of code

if (ncol(tbl) == 0) return(invisible())

  ifelse((nrow(tbl) == 0 ), obs<-0 ,obs <- nrow(tbl))
  cat(paste0("Observations: ",obs,"\n"))

  cat("Variables:\n")

@hadley hadley closed this in 5af063e Nov 19, 2014
krlmlr pushed a commit to krlmlr/dplyr that referenced this issue Mar 2, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants