Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.grouped_df too restrictive #733

Closed
Mullefa opened this issue Oct 29, 2014 · 3 comments
Closed

[.grouped_df too restrictive #733

Mullefa opened this issue Oct 29, 2014 · 3 comments
Assignees
Labels
Milestone

Comments

@Mullefa
Copy link

@Mullefa Mullefa commented Oct 29, 2014

If not all the grouping variables are specified, could instead a warning() be thrown, and a tbl_df be returned? The current implementation causes problem when a grouped_df is passed in place of a data frame to other users code, as arbitrary selection on columns is assumed.

@hadley
Copy link
Member

@hadley hadley commented Oct 30, 2014

I wonder if the warning is even necessary

@romainfrancois
Copy link
Member

@romainfrancois romainfrancois commented Oct 30, 2014

Maybe not. Just let me know what should happen.

@Mullefa
Copy link
Author

@Mullefa Mullefa commented Oct 31, 2014

Good point. I would say no: for the most part I think it will be used with
no grouping assumed.
On 30 Oct 2014 21:40, "Romain François" notifications@github.com wrote:

Maybe not. Just let me know what should happen.


Reply to this email directly or view it on GitHub
#733 (comment).

@hadley hadley closed this in 0e80f84 Nov 18, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants