Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate rbind_list and rbind_all #803

Closed
hadley opened this issue Nov 24, 2014 · 5 comments
Closed

Deprecate rbind_list and rbind_all #803

hadley opened this issue Nov 24, 2014 · 5 comments
Assignees
Labels
Milestone

Comments

@hadley
Copy link
Member

@hadley hadley commented Nov 24, 2014

No description provided.

@hadley hadley added the feature label Nov 24, 2014
@hadley hadley self-assigned this Nov 24, 2014
@hadley hadley added this to the 0.4 milestone Nov 24, 2014
@Mullefa
Copy link

@Mullefa Mullefa commented Jan 8, 2015

What would be used in its place? I love the speed of these function :)

@hadley
Copy link
Member Author

@hadley hadley commented Jan 8, 2015

bind_rows() - same implementation in C++, but better R side (combines both old functions) and better name

@Mullefa
Copy link

@Mullefa Mullefa commented Jan 8, 2015

Great - I could never remember whether rbind_list() took a list, or coerced its arguments to a list.

@thomasp85
Copy link
Member

@thomasp85 thomasp85 commented Jan 23, 2015

Will bind_rows() have support for matrices? I know everything dplyr is data.frame based (sort of) but the utility of the bind_rows()/rbind_all() is broader than dplyr. The overhead of converting the input to data.frames can be high, so it would be nice to have dispatch for matrices as well...

It seems it seems bind_impl is casting all input to DataFrame anyway so it should be fairly easy to include matrices... I could take a stab at it if you're willing to include it in dplyr. If so please let me know whether you have preferences for the interface...

@hadley
Copy link
Member Author

@hadley hadley commented Oct 29, 2015

@thomasp85 yes, I'd be willing to review that - please file as a separate issue

@hadley hadley closed this in b663a69 Oct 29, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants