Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mutate use collecter h #2487

Merged
merged 6 commits into from Mar 5, 2017
Merged

Make mutate use collecter h #2487

merged 6 commits into from Mar 5, 2017

Commits on Mar 2, 2017

  1. Add difftime support to Collecter.h 

    We want to support difftime in bind_rows and combine.

We are already supporting mutate and I'm preparing a PR
to make mutate use Collecter.h as well.
    @zeehio
    zeehio committed Mar 2, 2017
    Copy the full SHA
    a13f046 View commit details
    Browse the repository at this point in the history

  2. Fix oldrel test

    @zeehio
    zeehio committed Mar 2, 2017
    Copy the full SHA
    8dec9e8 View commit details
    Browse the repository at this point in the history

  3. Make mutate use collecter.h. Closes tidyverse#1892 

    `mutate(col2 = fun(col1))` on a grouped data frame calls `fun` once per group.

It used to require that `fun` returns the exact same type and that was not desirable in functions that may return different (but compatible) types, such as integer and numeric.

This PR changes that behaviour, so the returned vectors from each of the `fun` calls are combined using the same coercion rules than `combine` and `bind_rows`, defined in `Collecter.h`.
    @zeehio
    zeehio committed Mar 2, 2017
    Copy the full SHA
    4b2257d View commit details
    Browse the repository at this point in the history

  4. Add hms support and other @krlmlr feedback

    @zeehio
    zeehio committed Mar 2, 2017
    Copy the full SHA
    1231ced View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2017

  1. Further suggestions to PR tidyverse#2487 by @krlmlr

    @zeehio
    zeehio committed Mar 3, 2017
    Copy the full SHA
    c920544 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2017

  1. Difftime collecter corrections suggested by @hadley

    @zeehio
    zeehio committed Mar 4, 2017
    Copy the full SHA
    48f90e0 View commit details
    Browse the repository at this point in the history