Do not show progress bar if not interactive or knitr in progress #429
Conversation
|
Thanks! Would you mind adding a bullet to NEWS? (Might actually be best to hold off a couple of days until dplyr 0.2 gets to cran. In the middle of extended submission process) |
|
I added a note to the current news, I can edit it again if you reformat the news after the 0.2 cran release if needed, just ping me here if needed. Good luck with with the submission, I know from personal experience they can be frustrating. |
|
Could you please move the news into the correct location? Thanks! |
|
@hadley The news is moved and rebased. |
|
Hmmm, I think something's gone wrong because there are now a whole lot of commits from me in the PR. |
|
Maybe github gets confused when you rebase an existing pull request, I'll poke around some more. |
Checking a NULL value for true results in an error The previous commit correctly did not print the progress bar when knitting, but it also threw an error when not knitting, this commit fixes the issue in both cases Add note to news Correct issue number Move progress bar interactive use to latest news block Checking a NULL value for true results in an error The previous commit correctly did not print the progress bar when knitting, but it also threw an error when not knitting, this commit fixes the issue in both cases Add note to news Correct issue number
|
Ok this now should be good to go. |
Do not show progress bar if not interactive or knitr in progress
|
Thanks! |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
This was easy enough to _Just do it_™
Fixes #428