Add ... to signature of db_list_tables

[MichaelChirico]

We have an extension which needs further arguments. I'll file another PR so as not to break dbplyr shortly.

Actually I see that as of tidyverse/dbplyr#499, dbplyr no longer uses this generic. Will it be deprecated here as well?

[hadley]

@MichaelChirico the deprecation plan is described in https://dbplyr.tidyverse.org/articles/backend-2.html. I think you probably just want to modify the dbplyr generic.

[MichaelChirico]

Thanks... closing here. Will come back to this later.

[MichaelChirico]

@hadley looking at this again, I'm a bit confused. Did you mean to say to modify the dplyr generic?

db_list_tables isn't a part of dbplyr anymore from what I'm seeing at HEAD...

[hadley]

Sorry, I forgot which generics went where — instead of db_list_tables, dbplyr now uses DBI::dbListTables(). But it looks like that was only ever used as part of db_write_table() (https://dbplyr.tidyverse.org/articles/backend-2.html#unused-generics-1) so you might actually want to define a dbWriteTable() method. What are you trying to do?

[MichaelChirico]

We have a method that takes another argument to db_list_tables, but the generic doesn't have ..., so I was just going to add that to facilitate extensions.

We use db_list_tables directly for interactive cases, so dbWriteTable feels... indirect. Any thoughts?