Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove name argument from compute() generic #5783

Merged
merged 4 commits into from Mar 3, 2021

Conversation

ianmcook
Copy link
Contributor

@ianmcook ianmcook commented Feb 24, 2021

The name argument of the compute() generic is a vestige from the old days before dbplyr was broken out as a separate package. It would be best to remove it if doing so will not break any reverse dependencies.

Some dplyr backend packages need a method to force evaluation of lazy operations without assigning an external name to the materialized result where it's stored in the backend system. An example of this is the arrow R package.

It seems like this change should not break anything, because dplyr SQL backend packages should all use dbplyr::compute.tbl_sql() (which redefines the name argument) or else define their own compute() methods.

@romainfrancois
Copy link
Member

That seems reasonable although I'm not that familiar with compute(). I'll try to keep this in mind for the next round of revdep checks.

@romainfrancois romainfrancois merged commit 7683053 into tidyverse:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants