Remove name argument from compute() generic #5783
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
name
argument of thecompute()
generic is a vestige from the old days before dbplyr was broken out as a separate package. It would be best to remove it if doing so will not break any reverse dependencies.Some dplyr backend packages need a method to force evaluation of lazy operations without assigning an external name to the materialized result where it's stored in the backend system. An example of this is the arrow R package.
It seems like this change should not break anything, because dplyr SQL backend packages should all use
dbplyr::compute.tbl_sql()
(which redefines thename
argument) or else define their owncompute()
methods.