avoid warning about last_warnings()

[romainfrancois]

related to:

• importFrom lifecycle ... instead of import lifecycle r-lib/pillar#368
• specific importFrom lifecycle ... instead of import lifecycle tibble#955

[romainfrancois]

pillar and tibble were both using import lifecycle which creates an issue with dev rlang.

[romainfrancois]

🤔 this only seems to work locally:

── R CMD check results ─────────────────────────────────── dplyr 1.0.7.9000 ────
Duration: 2m 44.3s

0 errors v | 0 warnings v | 0 notes v

R CMD check succeeded

as opposed to this with released versions:

> checking Rd files ... WARNING
  prepare_Rd: replacing previous import ‘lifecycle::last_warnings’ by ‘rlang::last_warnings’ when loading ‘pillar’
  prepare_Rd: replacing previous import ‘lifecycle::last_warnings’ by ‘rlang::last_warnings’ when loading ‘tibble’

> checking for unstated dependencies in examples ... WARNING
  Warning: replacing previous import ‘lifecycle::last_warnings’ by ‘rlang::last_warnings’ when loading ‘pillar’
  Warning: replacing previous import ‘lifecycle::last_warnings’ by ‘rlang::last_warnings’ when loading ‘tibble’

> checking Rd line widths ... NOTE
  Warning: replacing previous import ‘lifecycle::last_warnings’ by ‘rlang::last_warnings’ when loading ‘pillar’
  Warning: replacing previous import ‘lifecycle::last_warnings’ by ‘rlang::last_warnings’ when loading ‘tibble’
  These lines will be truncated in the PDF manual.

0 errors v | 2 warnings x | 1 note x
Error: R CMD check found WARNINGs
In addition: Warning messages:
1: replacing previous import ‘lifecycle::last_warnings’ by ‘rlang::last_warnings’ when loading ‘tibble’ 
2: replacing previous import ‘lifecycle::last_warnings’ by ‘rlang::last_warnings’ when loading ‘pillar’ 
Execution halted

Exited with status 1.

same with dev versions of both, i.e. r-lib/pillar and tidyverse/tibble

[lionel-]

I'll also look into conditionally reexporting last_warnings() from rlang in lifecycle. I need to send a patch release soon for testthat compatibility as well.

[lionel-]

lifecycle 1.0.1 just got on CRAN to fix this warning.

[krlmlr]

I'll do a patch release today, should be on CRAN tomorrow (tibble usually shows false positives in CRAN's revdep checks).

[krlmlr]

Should have read more carefully. Dedicated imports are better anyway, we're double safe here. Can we close this PR?

[krlmlr]

Thanks @lionel- for taking care of this upstream, and @romainfrancois for the pulls.

[romainfrancois]

Merging this. The errors we see are unrelated.