Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deprecated functions noisier/defunct #6389

Merged
merged 13 commits into from
Aug 16, 2022
Merged

Make deprecated functions noisier/defunct #6389

merged 13 commits into from
Aug 16, 2022

Conversation

hadley
Copy link
Member

@hadley hadley commented Aug 4, 2022

Fixes #6387

@hadley hadley marked this pull request as ready for review August 16, 2022 19:38
Copy link
Member

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo!

R/defunct.r Outdated Show resolved Hide resolved
R/defunct.r Outdated Show resolved Hide resolved
Comment on lines 55 to 58
bench_tbl()
Condition
Error in `bench_tbl()`:
! could not find function "bench_tbl"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

READ YOUR SNAPSHOTS HADLEY

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOT MARKING EACH ERROR IS TOTALLY SAFE

@hadley hadley merged commit 925685a into main Aug 16, 2022
@hadley hadley deleted the defunct-updates branch August 16, 2022 21:09
This was referenced Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lifecycle updates
2 participants