-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize if_else/coalesce to fifelse/fcoalesce? #112
Comments
Yeah, I think that makes sense — it's just a matter of adding a few more lines to https://github.com/tidyverse/dtplyr/blob/master/R/tidyeval.R#L61-L75 |
@MichaelChirico I'm likely to be working on this in the next week if you want to take a stab at it. (If you don't have time, don't worry, as I can also do it myself) |
yes it's still on my to-do :)
…On Sat, Nov 2, 2019, 10:40 PM Hadley Wickham ***@***.***> wrote:
@MichaelChirico <https://github.com/MichaelChirico> I'm likely to be
working on this in the next week if you want to take a stab at it. (If you
don't have time, don't worry, as I can also do it myself)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#112?email_source=notifications&email_token=AB2BA5I5LNXMEKA43MLDKF3QRWGPJA5CNFSM4I6YT6VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC45KKQ#issuecomment-549049642>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2BA5P3IMHBSYMOJBMWBR3QRWGPJANCNFSM4I6YT6VA>
.
|
Heads up that we've also got |
data.table
now has its own implementation ofif_else
(fifelse
) andcoalesce
(fcoalesce
).I just tried the following: add two lines to
dplyr/tests/testthat.R
:then run
testthat::test_dir('tests')
.7 tests failed, but the same tests failed if I removed those two lines, so I'm taking that to mean
fifelse
andfcoalesce
pass usage testsdplyr
for behavior users expect of those functions.Does it make sense/would it be straightforward to optimize those functions when used in
dtplyr
?The text was updated successfully, but these errors were encountered: